Skip to content

fix: improve DA user experience #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 1, 2025
Merged

fix: improve DA user experience #268

merged 9 commits into from
Sep 1, 2025

Conversation

@akocbek
Copy link
Contributor

@akocbek akocbek commented Jul 2, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek akocbek requested a review from shemau as a code owner July 2, 2025 08:41
@akocbek
Copy link
Contributor Author

akocbek commented Jul 2, 2025

/run pipeline

@akocbek akocbek requested review from jor2 and ocofaigh and removed request for shemau July 2, 2025 09:16
@akocbek
Copy link
Contributor Author

akocbek commented Aug 26, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Aug 26, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Aug 26, 2025

/run pipeline

shemau
shemau previously approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh
Copy link
Contributor

ocofaigh commented Aug 26, 2025

Error: CreateTargetWithContext failed You have reached the limit of targets that you can define in your account: 16. Remove unused targets, then try again.

@ocofaigh
Copy link
Contributor

ocofaigh commented Aug 26, 2025

@daniel-butler-irl Are we getting rate limited?

❌ FAILED TESTS (1) - Complete Error Details
┌─────────────────────────────────────────────────────────────────────────────┐
│ 1/1 ❌ s4zpfi-dai-s-w-p-41-disable-dai-c-l[dai-a-i-b-rgas]                 │
│     📁 Prefix: s4zpfi-scc-pe41                                           │
│     🔧 Addons: Main: deploy-arch-ibm-scc-workload-protection (enabled)   │
│            Dependencies: 4 enabled, 1 disabled                             │
│            ✅ Enabled: deploy-arch-ibm-account-infra-base,                  │
│            deploy-arch-ibm-apprapp, deploy-arch-ibm-cloud-monitoring,      │
│            deploy-arch-ibm-activity-tracker                                │
│            ❌ Disabled: deploy-arch-ibm-cloud-logs                          │
│                                                                             │
│     🔴 TRANSIENT ERRORS:                                                    │
│     • failed after 5 attempts: error getting offering from catalog          │
│     '7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3' with offering ID                 │
│     '918453c3-4f97-4583-8c4a-83ef12fc7916-global': Too Many Requests        │
│                                                                             │

@daniel-butler-irl
Copy link

daniel-butler-irl commented Aug 27, 2025

Was this a once-off or consistent? I have a bunch of stuff already in place to slow it down and prevent ratelimiting.

@daniel-butler-irl
Copy link

daniel-butler-irl commented Aug 27, 2025

Also a separate issue in one of the other tests:

    "Result": {
 2025/08/26 16:43:15 Terraform apply |         "errors": [
 2025/08/26 16:43:15 Terraform apply |             {
 2025/08/26 16:43:15 Terraform apply |                 "code": "targets_limit_reached",
 2025/08/26 16:43:15 Terraform apply |                 "message": "You have reached the limit of targets that you can define in your account: 16. Remove unused targets, then try again."
 2025/08/26 16:43:15 Terraform apply |             }
 2025/08/26 16:43:15 Terraform apply |         ],
 2025/08/26 16:43:15 Terraform apply |         "status_code": 400,
 2025/08/26 16:43:15 Terraform apply |         "trace": "f8e89a52-bad6-4917-9420-a58e2f3afd36"
 2025/08/26 16:43:15 Terraform apply |     },
 2025/08/26 16:43:15 Terraform apply |     "RawResult": null

remember the summary is only for the permutation tests, other tests can still fail and need to be debugged as usual

@daniel-butler-irl
Copy link

daniel-butler-irl commented Aug 27, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Aug 29, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Sep 1, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Sep 1, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 57ca5aa into main Sep 1, 2025
2 checks passed
@ocofaigh ocofaigh deleted the improve_ui branch September 1, 2025 17:21
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Sep 1, 2025

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@shemau shemau shemau left review comments

@jor2 jor2 Awaiting requested review from jor2

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akocbek @ocofaigh @daniel-butler-irl @terraform-ibm-modules-ops @shemau